Project

General

Profile

« Previous | Next » 

Revision 1384

Added by Dietmar over 13 years ago

Security fix in admin/pages

View differences:

admin.php
5 5
 * @package         modules
6 6
 * @author          WebsiteBaker Project
7 7
 * @copyright       2004-2009, Ryan Djurovich
8
 * @copyright       2009-2011, Website Baker Org. e.V.
8
 * @copyright       2009-2010, Website Baker Org. e.V.
9 9
 * @link			http://www.websitebaker2.org/
10 10
 * @license         http://www.gnu.org/licenses/gpl.html
11
 * @platform        WebsiteBaker 2.9.x
11
 * @platform        WebsiteBaker 2.8.x
12 12
 * @requirements    PHP 5.2.2 and higher
13 13
 * @version         $Id$
14 14
 * @filesource		$HeadURL$
15 15
 * @lastmodified    $Date$
16 16
 *
17
 */
17
*/
18 18

  
19 19
// Stop this file being access directly
20 20
if(!defined('WB_URL')) {
......
23 23
}
24 24

  
25 25
// Get page id
26
if(isset($_GET['page_id']) && is_numeric($_GET['page_id']))
27
{
26
if(isset($_GET['page_id']) && is_numeric($_GET['page_id'])) {
28 27
	$page_id = (int)$_GET['page_id'];
29
} elseif(isset($_POST['page_id']) && is_numeric($_POST['page_id']))
30
{
28
} elseif(isset($_POST['page_id']) && is_numeric($_POST['page_id'])) {
31 29
	$page_id = (int)$_POST['page_id'];
32 30
} else {
33 31
	header("Location: index.php");
......
35 33
}
36 34

  
37 35
// Get section id if there is one
38
if(isset($_GET['section_id']) && is_numeric($_GET['section_id']))
39
{
36
if(isset($_GET['section_id']) && is_numeric($_GET['section_id'])) {
40 37
	$section_id = (int)$_GET['section_id'];
41
} elseif(isset($_POST['section_id']) && is_numeric($_POST['section_id']))
42
{
38
} elseif(isset($_POST['section_id']) && is_numeric($_POST['section_id'])) {
43 39
	$section_id = (int)$_POST['section_id'];
44 40
} else {
45 41
	// Check if we should redirect the user if there is no section id
46
	if(!isset($section_required))
47
	{
42
	if(!isset($section_required)) {
48 43
		$section_id = 0;
49 44
	} else {
50 45
		header("Location: $section_required");
......
56 51
$js_back = 'javascript: history.go(-1);';
57 52

  
58 53
// Create new admin object
59
include(WB_PATH.'/framework/class.admin.php');
60
// header will be set here, see database->is_error
54
require(WB_PATH.'/framework/class.admin.php');
61 55
$admin = new admin('Pages', 'pages_modify');
62 56

  
63 57
// Get perms
64
$sql  = 'SELECT `admin_groups`,`admin_users` FROM `'.TABLE_PREFIX.'pages` ';
65
$sql .= 'WHERE `page_id` = '.intval($page_id);
66
$ok = false;
67
if( ($res_pages = $database->query($sql)) )
68
{
69
	if( ($rec_pages = $res_pages->fetchRow()) )
70
	{
71
		if( $admin->ami_group_member($rec_pages['admin_groups']) || $admin->ami_group_member($rec_pages['admin_users']) )
72
		{
73
			$ok = true;
74
		}
75
	}
58
// $database = new database();
59
$results = $database->query("SELECT admin_groups,admin_users FROM ".TABLE_PREFIX."pages WHERE page_id = '$page_id'");
60
$results_array = $results->fetchRow();
61
$old_admin_groups = explode(',', str_replace('_', '', $results_array['admin_groups']));
62
$old_admin_users = explode(',', str_replace('_', '', $results_array['admin_users']));
63

  
64
$in_group = FALSE;
65
foreach($admin->get_groups_id() as $cur_gid){
66
    if (in_array($cur_gid, $old_admin_groups)) {
67
        $in_group = TRUE;
68
    }
76 69
}
77
if( !$ok ) { $admin->print_error($MESSAGE['PAGES']['INSUFFICIENT_PERMISSIONS']); }
70
if((!$in_group) && !is_numeric(array_search($admin->get_user_id(), $old_admin_users))) {
71
	echo $admin->get_group_id().$admin->get_user_id();
72
	print_r ($old_admin_groups);
73
	$admin->print_error($MESSAGE['PAGES']['INSUFFICIENT_PERMISSIONS']);
74
}
78 75

  
79
//$old_admin_groups = explode(',', str_replace('_', '', $rec_pages['admin_groups']));
80
//$old_admin_users  = explode(',', str_replace('_', '', $rec_pages['admin_users']));
81
//
82
//$in_group = FALSE;
83
//foreach($admin->get_groups_id() as $cur_gid)
84
//{
85
//    if (in_array($cur_gid, $old_admin_groups))
86
//	{
87
//        $in_group = TRUE;
88
//    }
89
//}
90
//if((!$in_group) && !is_numeric(array_search($admin->get_user_id(), $old_admin_users)))
91
//{
92
//	$admin->print_error($MESSAGE['PAGES']['INSUFFICIENT_PERMISSIONS']);
93
//}
94

  
95 76
// Workout if the developer wants to show the info banner
96
if(isset($print_info_banner) && $print_info_banner == true)
97
{
98
	// Get page details
99
	$sql  = 'SELECT `page_id`,`page_title`,`modified_by`,`modified_when` FROM `'.TABLE_PREFIX.'pages` ';
100
	$sql .= 'WHERE `page_id` = '.intval($page_id);
101
	$res_pages = $database->query($sql);
102
	if($database->is_error())
103
	{
104
		// $admin->print_header();  don't know why
105
		$admin->print_error($database->get_error());
106
	}
107
	if($res_pages->numRows() == 0)
108
	{
109
		// $admin->print_header();   don't know why
110
		$admin->print_error($MESSAGE['PAGES']['NOT_FOUND']);
111
	} else {
112
		$rec_pages = $res_pages->fetchRow();
113
	}
77
if(isset($print_info_banner) && $print_info_banner == true) {
78
	
79
// Get page details
80
// $database = new database();
81
$query = "SELECT page_id,page_title,modified_by,modified_when FROM ".TABLE_PREFIX."pages WHERE page_id = '$page_id'";
82
$results = $database->query($query);
83
if($database->is_error()) {
84
	$admin->print_header();
85
	$admin->print_error($database->get_error());
86
}
87
if($results->numRows() == 0) {
88
	$admin->print_header();
89
	$admin->print_error($MESSAGE['PAGES']['NOT_FOUND']);
90
}
91
$results_array = $results->fetchRow();
114 92

  
115
	// Get display name of person who last modified the page
116
	$user = $admin->get_user_details($rec_pages['modified_by']);
93
// Get display name of person who last modified the page
94
$user=$admin->get_user_details($results_array['modified_by']);
117 95

  
118
	// Convert the unix ts for modified_when to human a readable form
119
	if($rec_pages['modified_when'] != 0)
120
	{
121
		$modified_ts = gmdate(TIME_FORMAT.', '.DATE_FORMAT, $rec_pages['modified_when']+TIMEZONE);
122
	} else {
123
		$modified_ts = 'Unknown';
124
	}
96
// Convert the unix ts for modified_when to human a readable form
97
if($results_array['modified_when'] != 0) {
98
	$modified_ts = gmdate(TIME_FORMAT.', '.DATE_FORMAT, $results_array['modified_when']+TIMEZONE);
99
} else {
100
	$modified_ts = 'Unknown';
101
}
125 102

  
126
	// Include page info script
127
	$template = new Template(THEME_PATH.'/templates');
128
	$template->set_file('page', 'pages_modify.htt');
129
	$template->set_block('page', 'main_block', 'main');
130
	$template->set_var(array(
131
				'PAGE_ID' => $rec_pages['page_id'],
132
				'PAGE_TITLE' => ($rec_pages['page_title']),
133
				'MODIFIED_BY' => $user['display_name'],
134
				'MODIFIED_BY_USERNAME' => $user['username'],
135
				'MODIFIED_WHEN' => $modified_ts,
136
				'ADMIN_URL' => ADMIN_URL
137
				));
103
// Include page info script
104
$template = new Template(THEME_PATH.'/templates');
105
$template->set_file('page', 'pages_modify.htt');
106
$template->set_block('page', 'main_block', 'main');
107
$template->set_var(array(
108
					'PAGE_ID' => $results_array['page_id'],
109
					'PAGE_TITLE' => ($results_array['page_title']),
110
					'MODIFIED_BY' => $user['display_name'],
111
					'MODIFIED_BY_USERNAME' => $user['username'],
112
					'MODIFIED_WHEN' => $modified_ts,
113
					'ADMIN_URL' => ADMIN_URL
114
					)
115
				);
116
if($modified_ts == 'Unknown') {
117
	$template->set_var('DISPLAY_MODIFIED', 'hide');
118
} else {
119
	$template->set_var('DISPLAY_MODIFIED', '');
120
}
138 121

  
139
	$template->set_block('main_block', 'show_modify_block', 'show_modify');
140
	if($modified_ts == 'Unknown')
141
	{
142
    	$template->set_block('show_modify', '');
143
		$template->set_var('CLASS_DISPLAY_MODIFIED', 'hide');
144
	} else {
145
		$template->set_var('CLASS_DISPLAY_MODIFIED', '');
146
    	$template->parse('show_modify', 'show_modify_block', true);
147
	}
122
// Work-out if we should show the "manage sections" link
123
$query_sections = $database->query("SELECT section_id FROM ".TABLE_PREFIX."sections WHERE page_id = '$page_id' AND module = 'menu_link'");
124
if($query_sections->numRows() > 0) {
125
	$template->set_var('DISPLAY_MANAGE_SECTIONS', 'none');
126
} elseif(MANAGE_SECTIONS == 'enabled') {
127
	$template->set_var('TEXT_MANAGE_SECTIONS', $HEADING['MANAGE_SECTIONS']);
128
} else {
129
	$template->set_var('DISPLAY_MANAGE_SECTIONS', 'none');
130
}
148 131

  
149
	$template->set_block('main_block', 'show_section_block', 'show_section');
150
	// Work-out if we should show the "manage sections" link
151
    $sql  = 'SELECT `section_id` FROM `'.TABLE_PREFIX.'sections` ';
152
	$sql .= 'WHERE `page_id` = '.intval($page_id).' AND `module` = "menu_link"';
153
	if( ( $res_sections = $database->query($sql) ) && ($database->is_error() == false ) )
154
	{
155
		if($res_sections->numRows() > 0)
156
		{
157
			$template->set_block('show_section', '');
158
			$template->set_var('DISPLAY_MANAGE_SECTIONS', 'none');
159
		}elseif(MANAGE_SECTIONS == 'enabled')
160
		{
161
			$template->set_var('TEXT_MANAGE_SECTIONS', $HEADING['MANAGE_SECTIONS']);
162
    		$template->parse('show_section', 'show_section_block', true);
163
		}else {
164
			$template->set_block('show_section', '');
165
			$template->set_var('DISPLAY_MANAGE_SECTIONS', 'none');
166
		}
167
	} else {
168
		$admin->print_error($database->get_error());
169
	}
132
// Insert language TEXT
133
$template->set_var(array(
134
					'TEXT_CURRENT_PAGE' => $TEXT['CURRENT_PAGE'],
135
					'TEXT_CHANGE' => $TEXT['CHANGE'],
136
					'LAST_MODIFIED' => $MESSAGE['PAGES']['LAST_MODIFIED'],
137
					'TEXT_CHANGE_SETTINGS' => $TEXT['CHANGE_SETTINGS'],
138
					'HEADING_MODIFY_PAGE' => $HEADING['MODIFY_PAGE']
139
					)
140
				);
170 141

  
171
	// Insert language TEXT
172
	$template->set_var(array(
173
				'TEXT_CURRENT_PAGE' => $TEXT['CURRENT_PAGE'],
174
				'TEXT_CHANGE' => $TEXT['CHANGE'],
175
				'LAST_MODIFIED' => $MESSAGE['PAGES']['LAST_MODIFIED'],
176
				'TEXT_CHANGE_SETTINGS' => $TEXT['CHANGE_SETTINGS'],
177
				'HEADING_MODIFY_PAGE' => $HEADING['MODIFY_PAGE']
178
				));
142
// Parse and print header template
143
$template->parse('main', 'main_block', false);
144
$template->pparse('output', 'page');
179 145

  
180
	// Parse and print header template
181
	$template->parse('main', 'main_block', false);
182
	$template->pparse('output', 'page');
183 146
}
184 147

  
185 148
// Work-out if the developer wants us to update the timestamp for when the page was last modified
186
if(isset($update_when_modified) && $update_when_modified == true)
187
{
188
	$sql  = 'UPDATE `'.TABLE_PREFIX.'pages` ';
189
	$sql .= 'SET `modified_when` = '.time().', ';
190
	$sql .=     '`modified_by`   = '.intval($admin->get_user_id()).' ';
191
	$sql .=     'WHERE page_id   = '.intval($page_id);
192
	$database->query($sql);
149
if(isset($update_when_modified) && $update_when_modified == true) {
150
	$database->query("UPDATE ".TABLE_PREFIX."pages SET modified_when = '".time()."', modified_by = '".$admin->get_user_id()."' WHERE page_id = '$page_id'");
193 151
}
194 152

  
195
?>
153
?>

Also available in: Unified diff