Index: branches/2.8.x/CHANGELOG
===================================================================
--- branches/2.8.x/CHANGELOG	(revision 1758)
+++ branches/2.8.x/CHANGELOG	(revision 1759)
@@ -13,6 +13,10 @@
 
 
 
+17 Sep-2012 Build 1759 Dietmar Woellbrink (Luisehahne)
+! during Reformat/rebuild all existing access files in upgrade-script
+  root_parent will be set to page_id
+! change multi-dimensional arrays (variables) to similar arrays in framework/functions.php
 16 Sep-2012 Build 1758 Dietmar Woellbrink (Luisehahne)
 ! forgot to upload the install.php from wysiwyg modul in Revision 1756
 ! correcting some more SEC_ANCHOR 
Index: branches/2.8.x/wb/upgrade-script.php
===================================================================
--- branches/2.8.x/wb/upgrade-script.php	(revision 1758)
+++ branches/2.8.x/wb/upgrade-script.php	(revision 1759)
@@ -446,7 +446,7 @@
 /**********************************************************
  *  - Adding page_extended to settings table
  */
-echo "Adding/updating ppage_extended to settings table";
+echo "Adding/updating page_extended to settings table";
 $cfg = array(
 	'page_extended' => (defined('PAGE_EXTENDED') ? PAGE_EXTENDED : 'true'),
 );
@@ -654,12 +654,12 @@
  ALTER TABLE `wb_pages` CHANGE `page_icon` `page_icon` VARCHAR( 255 ) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL DEFAULT ''
  */
 	$dir = (WB_PATH.MEDIA_DIRECTORY);
-	echo '<h4>Upgrade '.MEDIA_DIRECTORY.'/ index.php protect files</h4><br />';
+	echo '<h4>Upgrade '.MEDIA_DIRECTORY.'/ index.php protect files</h4>';
 	$array = rebuildFolderProtectFile($dir);
 	if( sizeof( $array ) ){
-		print '<br /><strong>Upgrade '.sizeof( $array ).' '.MEDIA_DIRECTORY.'/ protect files</strong>'." $OK<br />";
+		print '<strong>Upgrade '.sizeof( $array ).' '.MEDIA_DIRECTORY.'/ protect files</strong>'." $OK<br />";
 	} else {
-		print '<br /><strong>Upgrade '.MEDIA_DIRECTORY.'/ protect files</strong>'." $FAIL!<br />";
+		print '<<strong>Upgrade '.MEDIA_DIRECTORY.'/ protect files</strong>'." $FAIL!<br />";
 		print implode ('<br />',$array);
 	}
 
@@ -666,7 +666,7 @@
 /**********************************************************
  * upgrade pages folder index access files
  */
-	echo '<h4>Upgrade /pages/ index.php access files</h4><br />';
+	echo '<h4>Upgrade /pages/ index.php access files</h4>';
 
     ///**********************************************************
     // *  - try to remove access files
@@ -674,7 +674,7 @@
 	$sTempDir = (defined('PAGES_DIRECTORY') && (PAGES_DIRECTORY != '') ? PAGES_DIRECTORY : '');
 	if(($sTempDir!='') && is_readable(WB_PATH.$sTempDir)==true) {
 	 	if(rm_full_dir (WB_PATH.$sTempDir, true )==false) {
-			$msg[] = '<strong>Could not delete existing access files</strong><br />';
+			$msg[] = '<strong>Could not delete existing access files</strong>';
 	 	} else {
 			$msg[] = createFolderProtectFile(rtrim( WB_PATH.$sTempDir,'/') );
         }
@@ -684,17 +684,20 @@
     // *  - Reformat/rebuild all existing access files
     // */
     $msg[] = "All existing access files anew format";
-    $sql = 'SELECT `page_id`,`link`, `level` FROM `'.TABLE_PREFIX.'pages` ORDER BY `link`';
-    if (($res_pages = $database->query($sql)))
+    $sql = 'SELECT `page_id`,`root_parent`,`link`, `level` FROM `'.TABLE_PREFIX.'pages` ORDER BY `link`';
+    if (($oPage = $database->query($sql)))
     {
         $x = 0;
-        while (($rec_page = $res_pages->fetchRow()))
+        while (($page = $oPage->fetchRow(MYSQL_ASSOC)))
         {
-            $filename = WB_PATH.PAGES_DIRECTORY.$rec_page['link'].PAGE_EXTENSION;
-            $msg = create_access_file($filename, $rec_page['page_id'], $rec_page['level']);
+            $sql = 'UPDATE `'.TABLE_PREFIX.'pages` '
+                 . 'SET `root_parent`='.$page['page_id'].' WHERE page_id = '.$page['page_id'];
+            if(!$database->query($sql)) {}
+            $filename = WB_PATH.PAGES_DIRECTORY.$page['link'].PAGE_EXTENSION;
+            $msg = create_access_file($filename, $page['page_id'], $page['level']);
             $x++;
         }
-        $msg[] = '<strong>Number of the anew formatted access files: '.$x.'</strong><br />';
+        $msg[] = '<strong>Number of new formatted access files: '.$x.'</strong>';
     }
 
 	print implode ('<br />',$msg);
@@ -712,12 +715,12 @@
  * upgrade posts folder index protect files
  */
 	$sPostsPath = WB_PATH.PAGES_DIRECTORY.'/posts';
-	echo '<h4>Upgrade /posts/ index.php protect files</h4><br />';
+	echo '<h4>Upgrade /posts/ index.php protect files</h4>';
 	$array = rebuildFolderProtectFile($sPostsPath);
 	if( sizeof( $array ) ){
-		print '<br /><strong>Upgrade '.sizeof( $array ).' /posts/ protect files</strong>'." $OK<br />";
+		print '<strong>Upgrade '.sizeof( $array ).' /posts/ protect files</strong>'." $OK<br />";
 	} else {
-		print '<br /><strong>Upgrade /posts/ protect files</strong>'." $FAIL!<br />";
+		print '<strong>Upgrade /posts/ protect files</strong>'." $FAIL!<br />";
 		print implode ('<br />',$array);
 	}
 
@@ -851,7 +854,7 @@
 		}
 		closedir($handle);
 	}
-	echo '<br />Modules reloaded<br />';
+	echo '<strong><br />Modules reloaded<br /></strong>';
 
 	////delete templates
 	//$database->query("DELETE FROM ".TABLE_PREFIX."addons WHERE type = 'template'");
@@ -864,7 +867,7 @@
 		}
 		closedir($handle);
 	}
-	echo '<br />Templates reloaded<br />';
+	echo '<strong><br />Templates reloaded<br /></strong>';
 
 	////delete languages
 	//$database->query("DELETE FROM ".TABLE_PREFIX."addons WHERE type = 'language'");
@@ -877,7 +880,7 @@
 		}
 		closedir($handle);
 	}
-	echo '<br />Languages reloaded<br />';
+	echo '<strong><br />Languages reloaded<br /></strong>';
 
 /**********************************************************
  *  - install new droplets
Index: branches/2.8.x/wb/admin/interface/version.php
===================================================================
--- branches/2.8.x/wb/admin/interface/version.php	(revision 1758)
+++ branches/2.8.x/wb/admin/interface/version.php	(revision 1759)
@@ -51,5 +51,5 @@
 
 // check if defined to avoid errors during installation (redirect to admin panel fails if PHP error/warnings are enabled)
 if(!defined('VERSION')) define('VERSION', '2.8.3');
-if(!defined('REVISION')) define('REVISION', '1758');
+if(!defined('REVISION')) define('REVISION', '1759');
 if(!defined('SP')) define('SP', '');
Index: branches/2.8.x/wb/framework/functions.php
===================================================================
--- branches/2.8.x/wb/framework/functions.php	(revision 1758)
+++ branches/2.8.x/wb/framework/functions.php	(revision 1759)
@@ -410,7 +410,10 @@
 	$retVal = false;
 	if(!is_dir($dir_name))
     {
+		// To create the folder with 0777 permissions, we need to set umask to zero.
+		$oldumask = umask(0) ;
 		$retVal = mkdir($dir_name, $dir_mode,$recursive);
+		umask( $oldumask ) ;
 	}
 	return $retVal;
 }
@@ -425,6 +428,7 @@
 function change_mode($sName, $iMode = 0)
 {
 	$bRetval = true;
+    $iErrorReporting = error_reporting(0);
 	$iMode = intval($iMode) & 0777; // sanitize value
 	if (strtoupper(substr(PHP_OS, 0, 3)) !== 'WIN')
 	{ // Only chmod if os is not windows
@@ -437,6 +441,7 @@
 			$bRetval = chmod($sName, $iMode);
 		}
 	}
+    error_reporting($iErrorReporting);
 	return $bRetval;
 }
 
@@ -480,7 +485,7 @@
 	$sql = 'SELECT `parent`, `level` FROM `'.TABLE_PREFIX.'pages` WHERE `page_id` = '.$page_id;
 
 	$query_page = $database->query($sql);
-	$fetch_page = $query_page->fetchRow();
+	$fetch_page = $query_page->fetchRow(MYSQL_ASSOC);
 	$parent = $fetch_page['parent'];
 	$level = $fetch_page['level'];
 	if($level == 1) {
@@ -549,7 +554,7 @@
 	// Get id's
 	$sql = 'SELECT `page_id` FROM `'.TABLE_PREFIX.'pages` WHERE `parent` = '.$parent;
 	if( ($query = $database->query($sql)) ) {
-		while($fetch = $query->fetchRow()) {
+		while($fetch = $query->fetchRow(MYSQL_ASSOC)) {
 			$subs[] = $fetch['page_id'];
 			// Get subs of this sub recursive
 			$subs = get_subs($fetch['page_id'], $subs);
@@ -735,7 +740,7 @@
 			// can only be dirs
 			if(!file_exists($acces_file)) {
 				if(!make_dir($acces_file)) {
-					$admin->print_error($MESSAGE['PAGES']['CANNOT_CREATE_ACCESS_FILE_FOLDER']);
+					$admin->print_error($MESSAGE['PAGES_CANNOT_CREATE_ACCESS_FILE_FOLDER']);
 				}
 			}
 		}
@@ -765,7 +770,7 @@
 		// Chmod the file
 		change_mode($filename);
 	} else {
-		$admin->print_error($MESSAGE['PAGES']['CANNOT_CREATE_ACCESS_FILE']);
+		$admin->print_error($MESSAGE['PAGES_CANNOT_CREATE_ACCESS_FILE']);
 	}
 	return;
  }
@@ -944,8 +949,8 @@
 		$sql .= 'FROM `'.TABLE_PREFIX.'pages` WHERE `page_id`='.$page_id;
 		$results = $database->query($sql);
 		if($database->is_error())    { $admin->print_error($database->get_error()); }
-		if($results->numRows() == 0) { $admin->print_error($MESSAGE['PAGES']['NOT_FOUND']); }
-		$results_array = $results->fetchRow();
+		if($results->numRows() == 0) { $admin->print_error($MESSAGE['PAGES_NOT_FOUND']); }
+		$results_array = $results->fetchRow(MYSQL_ASSOC);
 		$parent     = $results_array['parent'];
 		$level      = $results_array['level'];
 		$link       = $results_array['link'];
@@ -989,7 +994,7 @@
 		if(file_exists($filename))
 		{
 			if(!is_writable(WB_PATH.PAGES_DIRECTORY.'/')) {
-				$admin->print_error($MESSAGE['PAGES']['CANNOT_DELETE_ACCESS_FILE']);
+				$admin->print_error($MESSAGE['PAGES_CANNOT_DELETE_ACCESS_FILE']);
 			}else {
 				unlink($filename);
 				if( file_exists($directory) &&
